Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subresource move #157

Merged
merged 14 commits into from
Aug 9, 2023
Merged

subresource move #157

merged 14 commits into from
Aug 9, 2023

Conversation

hana-alice
Copy link

@hana-alice hana-alice commented Aug 3, 2023

Re: #

Changelog

  • texture barrier range.
  • 1-layer texture view A0 view on slice 0 of 3-layer texture view B0, while B0 is a 3-layer texture view on 6-layer texture C0 at first 3 slices, they are expect to be appear in resource graph in the following form(except cube and depthstencil):
    • C0 -> "C0"
    • B0 -> "C0/B0"
    • A0 -> "C0/B0/A0"
  • compute view plane id default to 0xFFFFFFFF indicating all(from 0 to max) layers, in other words, it's the acient resource.
  • compute view plane indicates which plane of current resource(maybe view), plane means the index of leaf resource under current node by std::tuple(basePlane, planeCount, firstSlice, sliceCount, firstMip, mipCount) order.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@hana-alice
Copy link
Author

hana-alice commented Aug 3, 2023

test case: cocos/cocos-example-custom-pipeline#1
texture array asset is misssing in current engine init flow now, updating.

@star-e star-e merged commit 5c701fc into star-e:v3.8.1-pipeline Aug 9, 2023
19 of 22 checks passed
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@hana-alice ❗ There was an error during the execution of the tasks. Please check the logs for more details.

star-e pushed a commit that referenced this pull request Aug 14, 2023
* subresource move (#157)
# Conflicts:
#	native/cocos/renderer/pipeline/custom/FrameGraphDispatcher.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants